Skip to content

[ISSUE #12899]♻️Use async fn for QueryMessageStore::query_message - #12912

Open
harryhawwy69 wants to merge 1 commit into
mxsm:mainfrom
harryhawwy69:refactor/query-message-store-async-fn
Open

harryhawwy69 wants to merge 1 commit into
mxsm:mainfrom
harryhawwy69:refactor/query-message-store-async-fn

Conversation

@harryhawwy69

Copy link
Copy Markdown
Contributor

Which Issue(s) This PR Fixes(Closes)

Brief Description

QueryMessageStore carries #[trait_variant::make(Send)] and declares query_message as async fn ... -> Result<Option<QueryMessageResult>, StoreError>, instead of spelling out impl Future<Output = ...> + Send. The explicit Sync bound, the borrowed request and the synchronous offset lookup are unchanged, and the unused use std::future::Future; leaves the module.

How Did You Test This Change?

  • cargo fmt -p rocketmq-broker -- --check
  • cargo check --locked -p rocketmq-broker --lib

@rocketmq-rust-bot

Copy link
Copy Markdown
Collaborator

🔊@harryhawwy69 🚀Thanks for your contribution🎉!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto merge Difficulty level/Easy Easy ISSUE ready to review refactor♻️ refactor code rocketmq-broker crate rust Pull requests that update Rust code waiting-review waiting review this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor♻️] Use async fn for QueryMessageStore::query_message

4 participants